fix: add schema name to datasource field in chart list#11278
Merged
nytai merged 3 commits intoapache:masterfrom Oct 15, 2020
Merged
fix: add schema name to datasource field in chart list#11278nytai merged 3 commits intoapache:masterfrom
nytai merged 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11278 +/- ##
==========================================
- Coverage 65.43% 55.96% -9.48%
==========================================
Files 831 404 -427
Lines 39528 13410 -26118
Branches 3598 3392 -206
==========================================
- Hits 25866 7505 -18361
+ Misses 13553 5723 -7830
- Partials 109 182 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etr2460
approved these changes
Oct 15, 2020
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
thanks for the quick fix! one comment (non-blocking)
superset/models/slice.py
Outdated
| if self.table.schema: | ||
| return f"{self.table.schema}.{self.table.table_name}" | ||
| return self.table.table_name | ||
| datasource = self.datasource |
Member
There was a problem hiding this comment.
any reason why we have this here if we're not handling self.table the same way?
I don't really care which we do, but let's be consistent (either table and datasource or self.table and self.datasource)
Member
Author
There was a problem hiding this comment.
looks like most methods in this model share this inconsistency 😕
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
This was referenced Nov 26, 2023
This was referenced Dec 14, 2023
This was referenced Dec 20, 2023
mistercrunch
added
🏷️ bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
see title and linked ticket
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION